<html>
<head><meta charset="utf-8"><title>name-mangling test failure · t-compiler/help · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/index.html">t-compiler/help</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/name-mangling.20test.20failure.html">name-mangling test failure</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="189693602"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/name-mangling%20test%20failure/near/189693602" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/name-mangling.20test.20failure.html#189693602">(Mar 04 2020 at 14:10)</a>:</h4>
<p>Over in the <a href="https://github.com/rust-lang/rust/pull/69478" target="_blank" title="https://github.com/rust-lang/rust/pull/69478">PR adding AVR as tier3</a>, we are getting this failure:</p>
<div class="codehilite"><pre><span></span>---- [ui] ui/symbol-names/basic.rs#legacy stdout ----
diff of stderr:

- error: symbol-name(_ZN5basic4main17h81759b0695851718E)
+ error: symbol-name(_ZN5basic4main17h7bbff4a01206d8c2E)
3    |
4 LL | #[rustc_symbol_name]

5    | ^^^^^^^^^^^^^^^^^^^^
5    | ^^^^^^^^^^^^^^^^^^^^
6
- error: demangling(basic::main::h81759b0695851718)
+ error: demangling(basic::main::h7bbff4a01206d8c2)
9    |
10 LL | #[rustc_symbol_name]
</pre></div>


<p>However, we can't see anything that we would have done that would affect name mangling — anyone have any clues for us?</p>



<a name="189695894"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/name-mangling%20test%20failure/near/189695894" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/name-mangling.20test.20failure.html#189695894">(Mar 04 2020 at 14:31)</a>:</h4>
<p><span class="user-mention" data-user-id="116155">@Jake Goulding</span> Maybe double-check any enums you might have modified? It could have caused the hash value of something unrelated to change.</p>



<a name="189696128"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/name-mangling%20test%20failure/near/189696128" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/name-mangling.20test.20failure.html#189696128">(Mar 04 2020 at 14:33)</a>:</h4>
<p><span class="user-mention" data-user-id="116155">@Jake Goulding</span> I suspect it is this change: <a href="https://github.com/rust-lang/rust/pull/69478/files#diff-81a4a44de0d0b41bdae14ca42259b723R39" target="_blank" title="https://github.com/rust-lang/rust/pull/69478/files#diff-81a4a44de0d0b41bdae14ca42259b723R39">https://github.com/rust-lang/rust/pull/69478/files#diff-81a4a44de0d0b41bdae14ca42259b723R39</a></p>



<a name="189696230"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/name-mangling%20test%20failure/near/189696230" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/name-mangling.20test.20failure.html#189696230">(Mar 04 2020 at 14:34)</a>:</h4>
<p>...adding a new abi changes the hashes of every symbol? even those that don't use that ABI? That seems... strange.</p>



<a name="189696247"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/name-mangling%20test%20failure/near/189696247" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/name-mangling.20test.20failure.html#189696247">(Mar 04 2020 at 14:34)</a>:</h4>
<p>Looking at the git logs, it seems that when <code>EfiApi</code> was added the symbol tests were simply updated.</p>



<a name="189696252"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/name-mangling%20test%20failure/near/189696252" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/name-mangling.20test.20failure.html#189696252">(Mar 04 2020 at 14:34)</a>:</h4>
<p>It seems _wrong_ TBH.</p>



<a name="189696420"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/name-mangling%20test%20failure/near/189696420" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/name-mangling.20test.20failure.html#189696420">(Mar 04 2020 at 14:36)</a>:</h4>
<p>You'll have to ask someone else what the intended behavior is here.</p>



<a name="189696966"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/name-mangling%20test%20failure/near/189696966" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/name-mangling.20test.20failure.html#189696966">(Mar 04 2020 at 14:41)</a>:</h4>
<p>Thank you for pointing to the previous changes. I should have thought to do that</p>



<a name="189699137"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/name-mangling%20test%20failure/near/189699137" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/name-mangling.20test.20failure.html#189699137">(Mar 04 2020 at 15:01)</a>:</h4>
<p>The <code>Rust</code> and <code>C</code> abi's are after <code>AvrInterrupt</code>, so adding <code>AvrInterrupt</code> caused their discriminant to increase.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>